Skip to content

Conversation

@remotesynth
Copy link
Collaborator

As per the recommendation, this updates all the relevant usages of localhost:4566 to localhost.localstack.cloud:4566. It also updates the FAQ to reflect this change.

Please review carefully. I tried to ensure that each place where this is updated is correct, as there were some places that the localhost:4566 URL seemed to be the correct still, but I could not test every change.

Address DOCS-35

As per the recommendation, this updates all the relevant usages of `localhost:4566` to `localhost.localstack.cloud:4566`. It also updates the FAQ to reflect this change.

**Please review carefully**. I tried to ensure that each place where this is updated is correct, as there were some places that the `localhost:4566` URL seemed to be the correct still, but I could not test every change.

Address [DOCS-35](https://linear.app/localstack/issue/DOC-35/docs-consistently-use-localhostlocalstackcloud4566-in-examples)
@cloudflare-workers-and-pages
Copy link

Deploying localstack-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a19dab
Status: ✅  Deploy successful!
Preview URL: https://3a99fe2d.localstack-docs.pages.dev
Branch Preview URL: https://stndardize-localhost-url.localstack-docs.pages.dev

View logs

Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pushing this standardization, which helps users to connect to LocalStack seamlessly (https://blog.localstack.cloud/2024-03-04-making-connecting-to-localstack-easier/) 🚀
/cc @simonrw

I skimmed over the AWS changes, and things are looking good.
⚠️ I would assume Snowflake works similarly, but that might be worth double-checking

-e AWS_ACCESS_KEY_ID=test \
-e AWS_SECRET_ACCESS_KEY=test \
-e AWS_ENDPOINT_URL=http://localhost:4566 \
-e AWS_ENDPOINT_URL=http://localhost.localstack.cloud:4566 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the work for Snowflake? It might be worth testing/checking with the Snowflake team.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for raising, i have requested confirmation from internal slack channel for the sig snowflake folks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants